Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #5100 Add viewbox to sankey #5102

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix: #5100 Add viewbox to sankey #5102

merged 1 commit into from
Dec 5, 2023
+5 −7

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Dec 4, 2023 •
edited
Loading

📑 Summary

Adds viewbox attr to sankey diagram

Resolves #5100

You have to set the useMaxWidth option for it to scale down properly.

image

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

@netlify Netlify
Copy link

netlify bot commented Dec 4, 2023 •
edited
Loading

✅ Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 160c7d3
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/656d6c8fb8f65100089c85c5
😎 Deploy Preview https://deploy-preview-5102--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sidharthv96 sidharthv96 mentioned this pull request Dec 4, 2023
Open
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

Merging #5102 (160c7d3) into develop (f81e4d4) will decrease coverage by 1.24%.
Report is 4 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5102      +/-   ##
===========================================
- Coverage    79.41%   78.18%   -1.24%     
===========================================
  Files          166      166              
  Lines        13871    13874       +3     
  Branches       705      705              
===========================================
- Hits         11016    10847     -169     
- Misses        2703     2873     +170     
- Partials       152      154       +2
Flag Coverage Δ
e2e 83.68% <100.00%> (-1.56%) ⬇️
unit 43.04% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ages/mermaid/src/diagrams/sankey/sankeyRenderer.ts 74.19% <100.00%> (ø)
packages/mermaid/src/setupGraphViewbox.js 77.77% <100.00%> (+0.31%) ⬆️

... and 19 files with indirect coverage changes

@sidharthv96 sidharthv96 added this to the v10 milestone Dec 4, 2023
@sidharthv96 sidharthv96 requested a review from nirname December 4, 2023 06:29
nirname
nirname approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@nirname nirname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@nirname nirname added this pull request to the merge queue Dec 5, 2023
Merged via the queue into develop with commit fe07e9d Dec 5, 2023
26 checks passed
@nirname nirname deleted the 5100_SankeyViewbox branch December 5, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirname nirname nirname approved these changes

Assignees
No one assigned
Labels
Area: Development fix Graph: Sankey Internals: Renderer Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
v10
Development

Successfully merging this pull request may close these issues.

Sankey diagrams are missing viewBox SVG attribute
2 participants
@sidharthv96 @nirname